Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2684
to look at the new patch set (#2).
Change subject: IMPALA-3276: consistently handle pin failure in
BTS::PrepareForRead()
......................................................................
IMPALA-3276: consistently handle pin failure in BTS::PrepareForRead()
BufferedTupleStream::PrepareForRead() can fail in all scenarios except
when the stream is all pinned. The basic problem is that reservations
in the BufferedBlockMgr are not dependable since they can be
overcommitted.
This patch changes the interface so that all callers have to handle pin
failures and updates the callsites.
Change-Id: Iacf1aba50d79b01acdc7269dc23f07b8c19a151a
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/buffered-tuple-stream.cc
M be/src/runtime/buffered-tuple-stream.h
5 files changed, 70 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/84/2684/2
--
To view, visit http://gerrit.cloudera.org:8080/2684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacf1aba50d79b01acdc7269dc23f07b8c19a151a
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
