Alex Behm has posted comments on this change. Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2762/1/fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java File fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java: Line 247: if (children_.get(0).getType().isScalarType(PrimitiveType.CHAR)) { > The way it was implemented before (in castChildCharsToStrings) is in the sa Looks like the confusing part was in line 249. That analyze() is redundant because super.analyze() already analyzed all children. The flow seems fine, but maybe add a small helper function for doing the cast. -- To view, visit http://gerrit.cloudera.org:8080/2762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aebac6849898693570bc3164fff40786c215358 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
