Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2762/3/fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java File fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java: Line 238: // we cast the CHAR-typed whenExprs and castExprs to STRING, > What are the castExprs? I think we only cast the whenExprs. I meant CASE exprs. (In this example: CASE a WHEN b THEN c, a is the CASE expr, so we cast a and b, but leave c alone). Fixed http://gerrit.cloudera.org:8080/#/c/2762/3/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java: Line 1701: // IMPALA-3155 > nit: we generally use this format Done -- To view, visit http://gerrit.cloudera.org:8080/2762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aebac6849898693570bc3164fff40786c215358 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
