Alex Behm has posted comments on this change. Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2762/2/fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java File fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java: Line 237: // Keep track of maximum compatible type of case expr and all when exprs. Add a comment that explains why we are doing these casts, e.g.: // Since we have no BE implementation of a CaseExpr with CHAR types, // we cast the CHAR-typed whenExprs to STRING, // TODO: This casting is not always correct and needs to be fixed, see IMPALA-1652. http://gerrit.cloudera.org:8080/#/c/2762/2/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java: Line 1701: // IMPALA-3155 add a brief explanation what behavior this test is asserting (that a CHAR type is returned when all THEN exprs are of type CHAR). -- To view, visit http://gerrit.cloudera.org:8080/2762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aebac6849898693570bc3164fff40786c215358 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
