Henry Robinson has posted comments on this change. Change subject: IMPALA-3077: Enable runtime filters when PHJ spills ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2783/4/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 676: runtime_filters_enabled_ = false; > i think it's confusing to set this global state now since it kind of gives Done. In fact, after talking with Dimitris and Alex it became clear that the IsInSubplan() check was redundant. Since we also want to deprecate the command line flag (which is superseded by the query option, and referred to an old version of this feature), I did that and then there is no situation in which runtime_filters_ should not be built in the BE. -- To view, visit http://gerrit.cloudera.org:8080/2783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a2d9ee03ccea6b674392584e4c7f272233571e Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
