Tim Armstrong has posted comments on this change. Change subject: IMPALA-3077: Enable runtime filters when PHJ spills ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2783/5/be/src/exec/hash-join-node.cc File be/src/exec/hash-join-node.cc: Line 235: if (!state->filter_bank()->ShouldDisableFilter(hash_tbl_->size())) { > This code is building the filters. I guess you meant to put this comment i Yep I did -- To view, visit http://gerrit.cloudera.org:8080/2783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a2d9ee03ccea6b674392584e4c7f272233571e Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
