Youwei Wang has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF ......................................................................
Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/1943/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 4300: // invalid input here; > nit: capital I, not ; Done Line 4306: TestIsNull("next_day('t1c7t0c9','sunDAY')", TYPE_TIMESTAMP); > can you also add tests with explicit timestamps as input to next_day, such Done http://gerrit.cloudera.org:8080/#/c/1943/3/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 580: std::string weekday_str = std::string( > don't use std:: in cc files. Done Line 580: std::string weekday_str = std::string( > wrap if it exceeds 90 chars, first argument should be in this line. Done Line 582: transform(weekday_str.begin(), weekday_str.end(), > single line (wrap lines at 90 chars). Done Line 604: int delta_days = day_idx - DayOfWeek(context, date).val; > nit: double space Done Line 605: delta_days = delta_days <= 0 ? delta_days + 7 : delta_days ; > here, too. Looks like there's several superflous spaces in this line. Done Line 610: TimestampVal new_date = AddSub<true, IntVal, Days, false>( > single line, you could also do this: return AddSub<true, IntVal, Days, fals Done -- To view, visit http://gerrit.cloudera.org:8080/1943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
