Youwei Wang has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1943/4/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 608: TimestampVal new_date = AddSub<true, IntVal, Days, false>(context, date, delta); > is there a reason to create a temporary here (just curious)? Done -- To view, visit http://gerrit.cloudera.org:8080/1943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
