Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2459: Implement next_day date/time UDF ......................................................................
Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/1943/5/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 4269: // next_day udf test for IMPALA-2459 wrap with separate function, then call that here. this test function is already way too long. Line 4272: TestTimestampValue("next_day('1916-06-05', 'SUN')", why not use the same date as above? that way i can see that the result is correct more easily. same for all the other test cases. Line 4301: // Explicit timestamp conversion tests what is this testing that wasn't tested above? http://gerrit.cloudera.org:8080/#/c/1943/5/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 579: we never have blank lines directly following the function header http://gerrit.cloudera.org:8080/#/c/1943/5/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: Line 152: /// Similar examples are: let's keep it brief and drop this and the next two lines, the first example is enough. -- To view, visit http://gerrit.cloudera.org:8080/1943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2721d236c096639a9e7d2df8a45ca888c6b3e83e Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
