Alex Behm has posted comments on this change. Change subject: IMPALA-3329: custom cluster tests: set -max_log_files to unlimited ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2759/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: Line 28: DEFAULT_IMPALA_MAX_LOG_FILES = os.environ.get('IMPALA_MAX_LOG_FILES', 10) This new env variable seems oddly specific. We already have the ability to pass daemon startup flags via --impalad_args, etc. Why can't we use the existing mechanism? For example, we could populate those options by default in the maps IMPALAD_ARGS, STATESTORE_ARGS, CATALOGD_ARGS in CustomClusterTestSuite, or something along those lines. -- To view, visit http://gerrit.cloudera.org:8080/2759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbb2a8616adcb0cd2fb838505117e0e9ba39083 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
