Alex Behm has posted comments on this change. Change subject: IMPALA-3329: custom cluster tests: set -max_log_files to unlimited ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2759/1/bin/impala-config.sh File bin/impala-config.sh: Line 195: : ${IMPALA_MAX_LOG_FILES:=10} Do we really need this here? Seems like things should work even if we don't set anything here. http://gerrit.cloudera.org:8080/#/c/2759/1/bin/run-all-tests.sh File bin/run-all-tests.sh: Line 176: rm -rf ${IMPALA_CUSTOM_CLUSTER_TEST_LOGS_DIR} Might be simpler to set IMPALA_MAX_LOG_FILES to 10 at the beginning of this file and restore at the bottom or is there a compelling argument against it? http://gerrit.cloudera.org:8080/#/c/2759/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: Line 28: DEFAULT_IMPALA_MAX_LOG_FILES = os.environ.get('IMPALA_MAX_LOG_FILES', 10) > If it's a matter of making the commit message more clear as to the intent, Thanks for the explanation, I'm convinced. -- To view, visit http://gerrit.cloudera.org:8080/2759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbb2a8616adcb0cd2fb838505117e0e9ba39083 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
