Michael Brown has posted comments on this change. Change subject: IMPALA-3329: custom cluster tests: set -max_log_files to unlimited ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2759/1/bin/impala-config.sh File bin/impala-config.sh: Line 195: : ${IMPALA_MAX_LOG_FILES:=10} > Do we really need this here? Seems like things should work even if we don't Done http://gerrit.cloudera.org:8080/#/c/2759/1/bin/run-all-tests.sh File bin/run-all-tests.sh: Line 176: rm -rf ${IMPALA_CUSTOM_CLUSTER_TEST_LOGS_DIR} > Might be simpler to set IMPALA_MAX_LOG_FILES to 10 at the beginning of this I was trying to keep things tight within the control block for custom cluster tests. With errexit in place, you never know when the wrong setting might be left exported to the environment. The risk here seemed lower. -- To view, visit http://gerrit.cloudera.org:8080/2759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbb2a8616adcb0cd2fb838505117e0e9ba39083 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
