Tim Armstrong has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/2779/4/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1735: Tuple Why not TupleRow* and TupleRow->SetTuple()? I think that should work the same. I think this is ok too, but a little non-standard. Line 1735: ; Extra ; Line 1762: if (output_row == output_row_end) break; Does this correctly handle the case where the batch is full? I'm not sure if the function can be called in that case, but maybe add a DCHECK at the top of the function? http://gerrit.cloudera.org:8080/#/c/2779/4/be/src/exec/hdfs-parquet-scanner.h File be/src/exec/hdfs-parquet-scanner.h: Line 277: /// Top-level tuples: Thanks! -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
