Alex Behm has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2779/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1729: int HdfsParquetScanner::TransferScratchTuples(ScratchTupleBatch* scratch_batch) { > I think the new version is just as readable, and it's way easier to reason Makes sense, thanks! http://gerrit.cloudera.org:8080/#/c/2779/3/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: Line 250: if (repeat_count_ == 0) { > You mean (repeat_count_ | literal_count_) ? I'm pretty sure & is incorrect Mostafa said he'll give your version a run and see. We can still fix it later if your version slightly better. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
