Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/2/testdata/workloads/functional-query/queries/QueryTest/parquet-continue-on-error.test File testdata/workloads/functional-query/queries/QueryTest/parquet-continue-on-error.test: Line 21: 10,10 > Should be easy to implement that behavior if so desired. Does the spec say Hmm, I was thinking of the case where the writer writes extra values for some reason but doesn't actually want them, but I think it would then update the page metadata to not include these items in addition to the column metadata. So this seems good. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
