Tim Armstrong has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2781/1/be/src/exec/delimited-text-parser.inline.h File be/src/exec/delimited-text-parser.inline.h: Line 58: // Only support up to 1GB in length for a slot. Truncate if necessary. > Yes. We probably need to replace the 1GB allocation limit documentation (if Yeah I'm a little concerned about silently truncating data - not sure if this is what we want to do. http://gerrit.cloudera.org:8080/#/c/2781/1/be/src/runtime/string-buffer.h File be/src/runtime/string-buffer.h: Line 67: buffer_size_ = 0; > Looking at ScannerContext::Stream::GetBytesInternal(), it appears that the Will you add a comment to explain this? Not your change but it would be good to fix it. http://gerrit.cloudera.org:8080/#/c/2781/1/tests/query_test/test_compressed_formats.py File tests/query_test/test_compressed_formats.py: Line 151: class TestLargeCompressedFile(ImpalaTestSuite): > It's actually run in exhaustive test run only now. See below. It doesn't ac Ah got it, thanks. -- To view, visit http://gerrit.cloudera.org:8080/2781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ed28083d809a86d801a9c063a0aa32c50d32b20 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
