Michael Ho has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2781/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: Line 114: lib_dir = impala_home + "/toolchain/snappy-1.0.5/lib:" + lib_dir > I think we need to reconsider this. It definitely should get the snappy ver How about replacing 'impala_home + toolchain' with $IMPALA_TOOLCHAIN ? I am not sure if there is a easy way to determine the snappy version. May be we should just rename 'snappy-<version>' to just 'snappy' in the toolchain directory ? -- To view, visit http://gerrit.cloudera.org:8080/2781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ed28083d809a86d801a9c063a0aa32c50d32b20 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
