Michael Ho has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2781/2/be/src/runtime/string-buffer.h File be/src/runtime/string-buffer.h: Line 98: if (buffer_ != NULL) pool_->TryFree(reinterpret_cast<uint8_t*>(buffer_), old_size); > Does this interact at all with the special value MemPools return for 0-leng I may consider removing this new interface if there is an interface to reset StringBuffer to a certain size so we avoid the wasted memory when growing StringBuffer. -- To view, visit http://gerrit.cloudera.org:8080/2781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ed28083d809a86d801a9c063a0aa32c50d32b20 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
