Tim Armstrong has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/7/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1781: // TODO: Consider compacting the output row batch to better handle cases where Maybe get rid of this comment to avoid confusion down the line. I don't think we'd want to do that unless we made major changes to memory transfer between nodes. We need to send completed resources up to the next node anyway, so we probably need to return a batch to release the resources. I don't think the overhead of processing a small batch matters too much if it happens every time the scanner processes 8mb of data. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
