Alex Behm has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/2779/6/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1164: pool->AcquireData(decompressed_data_pool_.get(), false); > Personally, I think it's more clear if you change this to scratch_batch_->m This was simply an omission on my part, thanks for catching it! Done. Line 1748: // We are materializing a collection with empty tuples. Add a NULL tuple to the > Do we need to distinguish here between zero-length tuples that exist and NU We do, and the current behavior is a bug, but it's consistent with the rest of the scanners. There is an existing JIRA to fix this: IMPALA-2826 Line 1754: int num_null_tuples = min(batch_->capacity() - batch_->num_rows(), > nit: I would just call this "num_tuples", they're technically NULL but that Works for me. Done. Line 1897: if (column_readers[0]->RowGroupAtEnd()) break; > nit: I think this should go in the while loop because it describes the logi Agreed. Done. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
