Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/5/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: Line 250: if (repeat_count_ == 0) { > Thanks, Mostafa! Let's leave it as is then, even if it is "magical" I feel kind of silly suggesting this, but if (repeat_count_ == 0 && literal_count_ == 0) should be exactly equivalent no? It will look a little less magical then. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
