Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/7/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: Line 236: // Reset all messages, but keep all already reported keys so that we do not report the > it is impossible to change the behavior this while counting distinct errors But this doesn't cause ErrorCount() to count accumulated distinct errors either. it counts: for GENERAL: the number of errors since last GetUnreportedErrors(). for others: the number of distinct errors since the beginning of the query. so the sum returned by ErrorCount() is a hybrid. That said, I'm okay with leaving this behavior alone in this patch, so okay, let's leave it. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
