Huaisi Xu has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/8/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 1189: if (VLOG_QUERY_IS_ON && !status.ok()) { I rethought about this again... I think the bug is error_log() wont be empty once an error occurred. so as long as report thread clears error log, runtime_state_->ErrorLog() is likely to crash impala. since print error map tries to copy messages.front() to a string stream. looks like this is not a race bug. (although we identified races..) So I think for end to end test I need a query that has one error in runtime state, and runs long enough such that report thread has a chance to clear it and this scan node is still running. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
