Huaisi Xu has posted comments on this change.
Change subject: IMPALA-3385: Fix crashes on accessing error_log
......................................................................
Patch Set 8:
Finally I got my release build... it was just slow.
I am able to recreate the original crash, and get another crash at,
void MergeErrorMaps(ErrorLogMap* left, const ErrorLogMap& right) {
BOOST_FOREACH(const ErrorLogMap::value_type& v, right) {
// Append generic message, append specific codes or increment count if
exists
if (v.first == TErrorCode::GENERAL) {
(*left)[v.first].messages.insert(
(*left)[v.first].messages.end(), v.second.messages.begin(),
v.second.messages.end());
} else {
if ((*left).count(v.first) > 0) {
(*left)[v.first].count += v.second.count;
} else {
(*left)[v.first].messages.push_back(v.second.messages.front());
<--here
(*left)[v.first].count = v.second.count;
}
}
}
}
So we should not so easy to refer to vector begin() or front().
--
To view, visit http://gerrit.cloudera.org:8080/2829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-HasComments: No
