Tim Armstrong has posted comments on this change. Change subject: Added support for building Impala Front End separately (and quickly) ......................................................................
Patch Set 2: (2 comments) Looking pretty good to me, I think we should just make the args more consistent. I was tempted to say that we should switch over to building the frontend with make always, but we can leave that to later work. http://gerrit.cloudera.org:8080/#/c/2875/2/bin/make_impala.sh File bin/make_impala.sh: Line 138: if [ $BUILD_TESTS -eq 1 ] We already have a solution to build a subset of make targets here (impalad/catalogd/statestored without the tests), so I think it'd be better to push down fe_only (or whatever we call) as an argument to make_impala.sh just to be more symmetrical. This might be more generally useful too. http://gerrit.cloudera.org:8080/#/c/2875/2/buildall.sh File buildall.sh: Line 143: fe fe_only to be unambiguous? -- To view, visit http://gerrit.cloudera.org:8080/2875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I486bb95757334f9df77c4a97150b2b34c5c0e2c4 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Misha Dmitriev <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
