Misha Dmitriev has posted comments on this change. Change subject: Added support for building Impala Front End separately (and quickly) ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2875/2/bin/make_impala.sh File bin/make_impala.sh: Line 138: if [ $BUILD_TESTS -eq 1 ] > We already have a solution to build a subset of make targets here (impalad/ I initially wanted to implement it that way. But then I realized that if someone later wants to add say "be_only", "common_only" etc, they would end up adding essentially duplicate code to both make_impala.sh and buildall.sh for each of these features. Having -cmake_only here means that no further changes to make_impala.sh will be needed. But since it's your project, it's ultimately up to you. Please let me know how you would like me to proceed. http://gerrit.cloudera.org:8080/#/c/2875/2/buildall.sh File buildall.sh: Line 143: fe > fe_only to be unambiguous? Will do. Line 291: MAKE_IMPALA_ARGS="${MAKE_IMPALA_ARGS} -build_type=${CMAKE_BUILD_TYPE}" : : if [ $BUILD_FE_ONLY -eq 1 ]; then : echo "Build frontend only" : $IMPALA_HOME/bin/make_impala.sh ${MAKE_IMPALA_ARGS} -cmake_only : make fe : exit 0 : fi > There's a lot that can happen before this, which seems to contradict that t Will do. I just wasn't sure whether or not the above stuff is a necessary prerequisite for building anything at all in impala. -- To view, visit http://gerrit.cloudera.org:8080/2875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I486bb95757334f9df77c4a97150b2b34c5c0e2c4 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Misha Dmitriev <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Misha Dmitriev <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
