Matthew Jacobs has posted comments on this change. Change subject: Added support for building Impala Front End separately (and quickly) ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2875/2/bin/make_impala.sh File bin/make_impala.sh: Line 138: if [ $BUILD_TESTS -eq 1 ] > Ah right, I see your point. Personally I'd prefer to keep it more consisten I think I'd prefer to push fe_only down as well. The duplication isn't ideal, but I think it'd be nice to have the consistency here as well, and also reduce reliance on buildall.sh if possible, which is a mess IMO. I try to avoid buildall.sh myself. Then ppl can use make_impala.sh and avoid the extra crap buildall.sh does. -- To view, visit http://gerrit.cloudera.org:8080/2875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I486bb95757334f9df77c4a97150b2b34c5c0e2c4 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Misha Dmitriev <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Misha Dmitriev <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
