Lars Volker has posted comments on this change.

Change subject: IMPALA-2686: Add breakpad crash handler to all daemons
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2028/9/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 82:     """Check that when a daemon crashes it writes a minidump file."""
> Well if the core dumps aren't generated and the minidump doesn't contain en
I verified that breakpad does not interfere with the process's ability to write 
core files, so they will write them after the minidump has been written. Is 
this test the only one that create core files when running successfully? I 
assumed we would clean them up globally after the tests have been run.

Maybe I misunderstood it all. Let's sync in person if you feel like I'm not 
getting it.


-- 
To view, visit http://gerrit.cloudera.org:8080/2028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Silvius Rus <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to