Casey Ching has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/2028/9/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: Line 82: """Check that when a daemon crashes it writes a minidump file.""" > I verified that breakpad does not interfere with the process's ability to w Ok thanks for verifying the core dump generation. About the core files accumulating over time, I think jenkins does clear them out somehow, probably archives them too. There's also developers to consider. Removing the core dump at the end of the test upon success would be great. Both of the above would require logic to locate the core file that you mentioned earlier. If you don't think its practical, I'm fine with going forward. We can always come back later if needed. -- To view, visit http://gerrit.cloudera.org:8080/2028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Silvius Rus <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
