Tim Armstrong has posted comments on this change. Change subject: IMPALA-3443: Replace BOOST_FOREACH with ranged for() ......................................................................
Patch Set 1: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 610: const int64_t& Fix this to just be int64_t Line 715: for (const int64_t& partition_id: partition_ids_) { Fix this to just be int64_t Line 833: for (const int64_t& partition_id: partition_ids_) { Fix this to just be int64_t http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 489: for (const SlotDescriptor* collection_slot: One line? http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/util/url-coding.cc File be/src/util/url-coding.cc: Line 179: for (const char& c: in) { No need to use reference. http://gerrit.cloudera.org:8080/#/c/2890/1/thirdparty/mustache/mustache.cc File thirdparty/mustache/mustache.cc: Line 66: for (const char& c: in) { No need to use reference. -- To view, visit http://gerrit.cloudera.org:8080/2890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae1ca36313e3562311b6418478bf54b6d9b0bf7d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
