Henry Robinson has posted comments on this change. Change subject: IMPALA-3443: Replace BOOST_FOREACH with ranged for() ......................................................................
Patch Set 1: (16 comments) http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/codegen/instruction-counter.cc File be/src/codegen/instruction-counter.cc: Line 148: for (CounterMap::value_type& counter: counters_) { > single line Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/common/status.cc File be/src/common/status.cc: Line 187: for (const string& s: status.msg_->details()) { > single line? Done Line 204: for (const string& s: msg_->details()) { > single line? Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 610: const int64_t& > Fix this to just be int64_t Done Line 715: for (const int64_t& partition_id: partition_ids_) { > Fix this to just be int64_t Done Line 833: for (const int64_t& partition_id: partition_ids_) { > Fix this to just be int64_t Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/runtime/buffered-block-mgr-test.cc File be/src/runtime/buffered-block-mgr-test.cc: Line 347: for (BufferedBlockMgr::Block* block: blocks) { > single line? Done Line 362: for (BufferedBlockMgr::Block* block: blocks) { > single line? Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 489: for (const SlotDescriptor* collection_slot: > One line? about two chars too long http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/testutil/mini-impala-cluster.cc File be/src/testutil/mini-impala-cluster.cc: Line 87: for (InProcessImpalaServer* server: impala_servers) { > single line, if it fits Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/util/dict-test.cc File be/src/util/dict-test.cc: Line 38: for (T i: values) { > singe line Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/util/hdfs-bulk-ops.cc File be/src/util/hdfs-bulk-ops.cc: Line 138: for (const HdfsOp& op: ops_) { > single line Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/util/thread.cc File be/src/util/thread.cc: Line 329: for (const Thread& thread: threads_) { > single line Done Line 337: // BOOST_FOREACH + ptr_vector + const are not compatible > remove comment Done http://gerrit.cloudera.org:8080/#/c/2890/1/be/src/util/url-coding.cc File be/src/util/url-coding.cc: Line 179: for (const char& c: in) { > No need to use reference. Done http://gerrit.cloudera.org:8080/#/c/2890/1/thirdparty/mustache/mustache.cc File thirdparty/mustache/mustache.cc: Line 66: for (const char& c: in) { > No need to use reference. Oops, this file is in thirdparty so shouldn't really be touched. -- To view, visit http://gerrit.cloudera.org:8080/2890 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae1ca36313e3562311b6418478bf54b6d9b0bf7d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
