Hello Marcel Kornacker, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2890
to look at the new patch set (#3).
Change subject: IMPALA-3443: Replace BOOST_FOREACH with ranged for()
......................................................................
IMPALA-3443: Replace BOOST_FOREACH with ranged for()
This patch doesn't use 'auto' for the loop index type, as it's not clear
yet where the savings in typing outweigh the cost of eliding the type.
Change-Id: Iae1ca36313e3562311b6418478bf54b6d9b0bf7d
---
M be/src/benchmarks/thread-create-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/codegen/instruction-counter.cc
M be/src/common/status.cc
M be/src/exec/catalog-op-executor.cc
M be/src/exec/data-sink.cc
M be/src/exec/data-source-scan-node.cc
M be/src/exec/hash-join-node.cc
M be/src/exec/hbase-scan-node.cc
M be/src/exec/hbase-table-writer.cc
M be/src/exec/hdfs-avro-scanner.cc
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/hdfs-scan-node.cc
M be/src/exec/hdfs-table-sink.cc
M be/src/exec/incr-stats-util.cc
M be/src/exec/kudu-scan-node-test.cc
M be/src/exec/kudu-scan-node.cc
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-table-sink-test.cc
M be/src/exec/kudu-table-sink.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/exprs/expr-codegen-test.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/in-predicate-benchmark.cc
M be/src/resourcebroker/resource-broker.cc
M be/src/rpc/rpc-trace.cc
M be/src/runtime/buffered-block-mgr-test.cc
M be/src/runtime/buffered-block-mgr.cc
M be/src/runtime/buffered-tuple-stream.cc
M be/src/runtime/client-cache.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/data-stream-recvr.cc
M be/src/runtime/descriptors.cc
M be/src/runtime/disk-io-mgr-reader-context.cc
M be/src/runtime/disk-io-mgr.cc
M be/src/runtime/lib-cache.cc
M be/src/runtime/mem-tracker.cc
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/sorted-run-merger.cc
M be/src/runtime/sorter.cc
M be/src/runtime/timestamp-parse-util.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/types.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/query-resource-mgr.cc
M be/src/scheduling/query-schedule.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server-callbacks.cc
M be/src/service/impala-server.cc
M be/src/service/query-exec-state.cc
M be/src/service/query-options.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
M be/src/testutil/mini-impala-cluster.cc
M be/src/util/codec.cc
M be/src/util/collection-metrics.h
M be/src/util/debug-util.cc
M be/src/util/dict-encoding.h
M be/src/util/dict-test.cc
M be/src/util/error-util.cc
M be/src/util/error-util.h
M be/src/util/hdfs-bulk-ops.cc
M be/src/util/logging-support.cc
M be/src/util/memory-metrics.cc
M be/src/util/metrics.cc
M be/src/util/metrics.h
M be/src/util/network-util.cc
M be/src/util/runtime-profile-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/thread.cc
M be/src/util/url-coding.cc
M be/src/util/webserver.cc
75 files changed, 286 insertions(+), 368 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/90/2890/3
--
To view, visit http://gerrit.cloudera.org:8080/2890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iae1ca36313e3562311b6418478bf54b6d9b0bf7d
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
