CT internal requires PK? Is that what we scoped? Sorry, on my phone On Thu, Apr 28, 2016 at 4:24 PM Casey Ching (Code Review) < [email protected]> wrote:
> Casey Ching has posted comments on this change. > > Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for > PRIMARY KEY > ...................................................................... > > > Patch Set 3: > > > > > Just curious, is this necessary for the CREATE TABLE for > > internal > > > > Kudu tables? > > > > > > No not really. It's just a massive pain to make sense of the > > > existing rules. This should make future create table related > > > language changes easier. > > > > Gotcha. Would you be able to post the review for the CREATE TABLE > > case handling internal tables before iterating on this? It'd be > > good to get that stuff wrapped up and this looks like this one will > > take a while. If they're conflicting, I do think we should get the > > review to get the internal case handled sooner since that's on the > > short term roadmap we discussed in the sync up. > > Doing both the refactor and adding the primary key without the refactor > would mean going through the "massive pain" twice. It's probably best to > avoid if possible. > > -- > To view, visit http://gerrit.cloudera.org:8080/2865 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: I9a2b9e380a0b90c0e2e6f10f6905cab5164cb3c4 > Gerrit-PatchSet: 3 > Gerrit-Project: Impala > Gerrit-Branch: cdh5-trunk > Gerrit-Owner: Casey Ching <[email protected]> > Gerrit-Reviewer: Alex Behm <[email protected]> > Gerrit-Reviewer: Casey Ching <[email protected]> > Gerrit-Reviewer: Matthew Jacobs <[email protected]> > Gerrit-HasComments: No >
