Ya it's really basic for SQL. The issue is https://issues.cloudera.org/browse/IMPALA-2848 it's in the scope doc too.
On Thursday, April 28, 2016, Matthew Jacobs <[email protected]> wrote: > CT internal requires PK? Is that what we scoped? > > Sorry, on my phone > On Thu, Apr 28, 2016 at 4:24 PM Casey Ching (Code Review) < > [email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>> > wrote: > >> Casey Ching has posted comments on this change. >> >> Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for >> PRIMARY KEY >> ...................................................................... >> >> >> Patch Set 3: >> >> > > > Just curious, is this necessary for the CREATE TABLE for >> > internal >> > > > Kudu tables? >> > > >> > > No not really. It's just a massive pain to make sense of the >> > > existing rules. This should make future create table related >> > > language changes easier. >> > >> > Gotcha. Would you be able to post the review for the CREATE TABLE >> > case handling internal tables before iterating on this? It'd be >> > good to get that stuff wrapped up and this looks like this one will >> > take a while. If they're conflicting, I do think we should get the >> > review to get the internal case handled sooner since that's on the >> > short term roadmap we discussed in the sync up. >> >> Doing both the refactor and adding the primary key without the refactor >> would mean going through the "massive pain" twice. It's probably best to >> avoid if possible. >> >> -- >> To view, visit http://gerrit.cloudera.org:8080/2865 >> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >> >> Gerrit-MessageType: comment >> Gerrit-Change-Id: I9a2b9e380a0b90c0e2e6f10f6905cab5164cb3c4 >> Gerrit-PatchSet: 3 >> Gerrit-Project: Impala >> Gerrit-Branch: cdh5-trunk >> Gerrit-Owner: Casey Ching <[email protected] >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> >> Gerrit-Reviewer: Alex Behm <[email protected] >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> >> Gerrit-Reviewer: Casey Ching <[email protected] >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> >> Gerrit-Reviewer: Matthew Jacobs <[email protected] >> <javascript:_e(%7B%7D,'cvml','[email protected]');>> >> Gerrit-HasComments: No >> > -- > You received this message because you are subscribed to the Google Groups > "impala-cr" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <javascript:_e(%7B%7D,'cvml','impala-cr%[email protected]');>. > For more options, visit https://groups.google.com/a/cloudera.com/d/optout. >
