Alex Behm has posted comments on this change. Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY ......................................................................
Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/2865/3/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: Line 946: create_tbl_stmt ::= This is indeed what I had in mind! The parser looks much saner now, nice! Line 951: partitioned_data_arrangement:data_arrangement Does data_arrangement_val cause an issue here? I'd prefer to parse this version and throw an AnalysisError. Line 1021: data_arrangement_val ::= we typically use something like: data_arrangement_clause http://gerrit.cloudera.org:8080/#/c/2865/3/fe/src/main/java/com/cloudera/impala/analysis/TableDataArrangementClause.java File fe/src/main/java/com/cloudera/impala/analysis/TableDataArrangementClause.java: Line 21: class TableDataArrangementClause { Do you intend to add the new PRIMARY KEY clause in here? http://gerrit.cloudera.org:8080/#/c/2865/3/fe/src/main/java/com/cloudera/impala/analysis/TableDefClause.java File fe/src/main/java/com/cloudera/impala/analysis/TableDefClause.java: Line 21: class TableDefClause { Do you think it makes sense to move some of the CreateTableStmt.analyze() code into these new *Clause classes? I had a cursory glance and it seems to make sense. http://gerrit.cloudera.org:8080/#/c/2865/3/fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java File fe/src/test/java/com/cloudera/impala/analysis/ParserTest.java: Line 2379 don't we have other DISTRIBUTE BY tests that might need to be fixed? -- To view, visit http://gerrit.cloudera.org:8080/2865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a2b9e380a0b90c0e2e6f10f6905cab5164cb3c4 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
