Tim Armstrong has posted comments on this change. Change subject: IMPALA-1583: Simplify PartitionedHashJoinNode::ProcessProbeBatch() ......................................................................
Patch Set 3: Code-Review+1 (6 comments) Looking good, I think we should consider fixing a couple of low-hanging fruit that the refactoring revealed but I think the patch is great as-is. http://gerrit.cloudera.org:8080/#/c/2893/3/be/src/exec/partitioned-hash-join-node-ir.cc File be/src/exec/partitioned-hash-join-node-ir.cc: Line 59: matched_probe_ = true; I don't think we need this for inner joins, right? Line 98: matched_probe_ = true; I don't htink we use this in this join mode, right? Line 112: bool IR_ALWAYS_INLINE PartitionedHashJoinNode::ProcessProbeRowLeftSemiJoins( I feel like this function could still maybe be broken down further. I don't think we need tackle that in this patch though. Line 187: while (!hash_tbl_iterator_.AtEnd()) { Could be simplified to: for (; !hash_tbl_iterator_.AtEnd(); hash_tbl_iterator_.NextDuplicate()) Since I think NextDuplicate() is called on both paths back to the top of the loop. I think this is true for some/all of the other join modes. Line 234: matched_probe_ = false; I don't think we need this for all join modes, but it may not be worth special casing it here. http://gerrit.cloudera.org:8080/#/c/2893/3/be/src/exec/partitioned-hash-join-node.h File be/src/exec/partitioned-hash-join-node.h: Line 201: attached "appended"? here and a couple of other places. -- To view, visit http://gerrit.cloudera.org:8080/2893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2091bdf97ab34c5cdc84e84394c579a5b36afc0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
