Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-1583: Simplify PartitionedHashJoinNode::ProcessProbeBatch() ......................................................................
IMPALA-1583: Simplify PartitionedHashJoinNode::ProcessProbeBatch() PartitionedHashJoinNode::ProcessProbeBatch() is templatized to deal with various join types. It's rather hard to follow with logic of probing of different join types mixed together and goto statements interleaved in between. This change mechanically refactors the probing logic into four different functions: one for inner joins, one for outer joins, one for left semi joins and one for right semi joins. The code is still templatized so with inlining, the generated code should be about the same as before. Change-Id: Ie2091bdf97ab34c5cdc84e84394c579a5b36afc0 Reviewed-on: http://gerrit.cloudera.org:8080/2893 Reviewed-by: Michael Ho <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/partitioned-hash-join-node-ir.cc M be/src/exec/partitioned-hash-join-node.h M be/src/runtime/row-batch.h 3 files changed, 362 insertions(+), 175 deletions(-) Approvals: Michael Ho: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2091bdf97ab34c5cdc84e84394c579a5b36afc0 Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
