Michael Ho has posted comments on this change. Change subject: IMPALA-1583: Simplify PartitionedHashJoinNode::ProcessProbeBatch() ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/2893/3/be/src/exec/partitioned-hash-join-node-ir.cc File be/src/exec/partitioned-hash-join-node-ir.cc: Line 59: matched_probe_ = true; > I don't think we need this for inner joins, right? Removed. Line 98: matched_probe_ = true; > I don't htink we use this in this join mode, right? Removed. Line 187: while (!hash_tbl_iterator_.AtEnd()) { > Could be simplified to: Almost. One small thing is when the out_batch is full, we need to bump the iterator to the next duplicate before returning. http://gerrit.cloudera.org:8080/#/c/2893/3/be/src/exec/partitioned-hash-join-node.h File be/src/exec/partitioned-hash-join-node.h: Line 201: attached > "appended"? here and a couple of other places. Done -- To view, visit http://gerrit.cloudera.org:8080/2893 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2091bdf97ab34c5cdc84e84394c579a5b36afc0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
