Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/11/tests/query_test/test_errorlog.py File tests/query_test/test_errorlog.py: Line 29: class TestErrorLogs(ImpalaTestSuite): > I don't know what you are saying. Are you saying we still don't have a reg BTW, when I say "repros the crash", hitting the DCHECK(!messages.empty()) that you added to the old code to test is sufficient. Basically, I want to make sure we're exercising the code path that can lead to a crash in the old code (read from empty() vector). -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
