Huaisi Xu has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/2829/11/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 1204: ss << endl; > huh? doesn't VLOG always put an endl at the end? e.g. see line 1183. I'm p Done. where did you find out this in code? http://gerrit.cloudera.org:8080/#/c/2829/11/tests/query_test/test_errorlog.py File tests/query_test/test_errorlog.py: Line 29: class TestErrorLogs(ImpalaTestSuite): > BTW, when I say "repros the crash", hitting the DCHECK(!messages.empty()) t As discussed on Hangout, we agreed that this test does not need to crash impala pre-fix. This test covers some of the uncovered code path. and the unit test I included in error-util-test covers the rest code path handling edge cases. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
