Huaisi Xu has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log ......................................................................
Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/2829/12/be/src/util/error-util-test.cc File be/src/util/error-util-test.cc: Line 76: ASSERT_EQ(1, right[TErrorCode::GENERAL].messages.size()); > This validation code is not correct now that you aren't merging into 'right Done Line 85: ASSERT_EQ(1, cleared[TErrorCode::GENERAL].messages.size()); > same for this validation code now that right wasn't the one updated in 63-6 Done http://gerrit.cloudera.org:8080/#/c/2829/12/tests/query_test/test_errorlog.py File tests/query_test/test_errorlog.py: Line 16: @SkipIfLocal.hbase > do we still need these if we limit to text format? I think not, but I am not 100% sure. I use text format because it is sufficient to cover the code path already. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 12 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
