Tim Armstrong has posted comments on this change. Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2909/2/be/CMakeLists.txt File be/CMakeLists.txt: Line 138: # BOOST_NO_EXCEPTIONS: we can't handle exceptions in codegen'd code. > nit: put one more space before BOOST to line up with -W options Done http://gerrit.cloudera.org:8080/#/c/2909/2/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: Line 778: namespace boost { > Even though most (all?) exceptions come from scalar fn calls, I would put t I moved it to expr.cc . We don't need to cross-compile it so it seems better not to put it in impala-ir.cc Line 784: LOG(FATAL) << "Cannot handle exceptions in codegen'd code " << e.what(); > It's kind of unfortunate that this precludes gracefully handling boost exce The macro name is kind of misleading: one of the use cases is to use the handler to throw a custom exception class rather than a boost exception. So it might even make it easier to gracefully handle boost exceptions if we wanted to go down that path. -- To view, visit http://gerrit.cloudera.org:8080/2909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
