Skye Wanderman-Milne has posted comments on this change. Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2909/2/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: Line 784: LOG(FATAL) << "Cannot handle exceptions in codegen'd code " << e.what(); > The macro name is kind of misleading: one of the use cases is to use the ha True, although I imagine if we throw a new exception we'll lose the perf benefits... maybe not though? If we care about regressing perf if/when we catch these exceptions you might want to benchmark, not sure if it's worth worrying about though. -- To view, visit http://gerrit.cloudera.org:8080/2909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
