Tim Armstrong has posted comments on this change. Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2909/4/be/src/exprs/expr.cc File be/src/exprs/expr.cc: Line 736: void throw_exception(std::exception const &e) { > what does this have to do with exprs? Cross-compiled exprs (either aggregate functions or scalar functions) are the only place that these exceptions should be coming from, so I was thinking about it as expr error-handling. We could also put it under codegen somewhere. We could putit in it's own .cc file but then we'd have to force the linker to include it (it's only resolved dynamically). -- To view, visit http://gerrit.cloudera.org:8080/2909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
