Henry Robinson has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs ......................................................................
Patch Set 5: (4 comments) Looks pretty good to me, just a couple of questions. http://gerrit.cloudera.org:8080/#/c/2800/5/be/src/common/global-flags.cc File be/src/common/global-flags.cc: Line 70: A switch to enable/disable loading "If true, load " Line 73: principal Kerberos principal http://gerrit.cloudera.org:8080/#/c/2800/5/fe/src/main/java/com/cloudera/impala/service/BackendConfig.java File fe/src/main/java/com/cloudera/impala/service/BackendConfig.java: Line 25: public static BackendConfig INSTANCE Do you know if there will be one of these per query, or one per JVM instance (which i think is reused across queries)? In the latter case this will not work correctly. http://gerrit.cloudera.org:8080/#/c/2800/5/fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java File fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java: Line 1722: TestShortUsernameWithAuthToLocal Do you have a test for malformed rules? What's the user experience in that case? -- To view, visit http://gerrit.cloudera.org:8080/2800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
