Alex Behm has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2800/3/fe/src/main/java/com/cloudera/impala/authorization/AuthorizationChecker.java File fe/src/main/java/com/cloudera/impala/authorization/AuthorizationChecker.java: Line 117: throw new InternalException("Error calling getShortName() for user: " > - I think this is not exactly an AuthzException since we didn't even try to Treating this as an AuthException may lead to user confusion, and seems misleading as to what the root cause of the problem is. For example, a fix to this AuthException will most definitely not involve anything configured in Sentry - but that's what an AuthException typically means. If we hit this exception it seems like a Hadoop/OS misconfiguration. I'm in favor of either leaving the IOException or converting to an InternalException. -- To view, visit http://gerrit.cloudera.org:8080/2800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
