Henry Robinson has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2800/5/fe/src/main/java/com/cloudera/impala/service/BackendConfig.java File fe/src/main/java/com/cloudera/impala/service/BackendConfig.java: Line 25: public static BackendConfig INSTANCE > It is reused across lifetime of impalad. Can you please expand on why it wo Ah, of course the JniFrontend is also created only once. My bad, this is fine I think. http://gerrit.cloudera.org:8080/#/c/2800/5/fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java File fe/src/test/java/com/cloudera/impala/analysis/AuthorizationTest.java: Line 1722: TestShortUsernameWithAuthToLocal > If the rules are malformed, namenode won't start. It throws an exception in Remember that there may not be a namenode (S3-only deployments, for example). -- To view, visit http://gerrit.cloudera.org:8080/2800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76485b83c14ba26f6fce66e5f83e8014667829e0 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
