Tim Armstrong has posted comments on this change. Change subject: IMPALA-3337: fix "Cancelled" warnings when LIMIT clause is specified ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2964/1/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: Line 651: Status HdfsScanner::CheckAbortOnError(const ErrorMsg& message) const { > I figured it was implied by "AbortOnError" since that's the non-abort behav I think the new name is clearer than CheckAbortOnError so I'm ok with it. Something like HandleParseError() or HandleScanError()? It seems like the idea of the function is to decide what to do given an error during scanning. http://gerrit.cloudera.org:8080/#/c/2964/1/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: Line 408: non > Removed. Let me know if you had something else in mind. I was ok with this previous version (this is ok too), I was just getting confused about non-ok Status vs non-ok ErrorMsg objects. -- To view, visit http://gerrit.cloudera.org:8080/2964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a91a22608e346ca21a23ea66c855eae54bbced6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
