Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3337: fix "Cancelled" warnings when LIMIT clause is specified ......................................................................
IMPALA-3337: fix "Cancelled" warnings when LIMIT clause is specified The cancelled status is propagated in scanner threads to cause them to shut down once the limit has been satisified, but depending on the code path and when abort_on_error=false, this internal status would sometimes incorrectly end up in the error log. Fix this by factoring out the abort_on_error handling code so that it's handled more consistently across scanners. Parquet, RC, and Avro all suffered from this bug. Testing: exhastive Change-Id: I4a91a22608e346ca21a23ea66c855eae54bbced6 Reviewed-on: http://gerrit.cloudera.org:8080/2964 Reviewed-by: Tim Armstrong <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Internal Jenkins --- M be/src/exec/base-sequence-scanner.cc M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-rcfile-scanner.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-scanner.h M be/src/exec/hdfs-text-scanner.cc M tests/query_test/test_scanners.py 7 files changed, 45 insertions(+), 36 deletions(-) Approvals: Internal Jenkins: Verified Dan Hecht: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/2964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a91a22608e346ca21a23ea66c855eae54bbced6 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]>
