Dan Hecht has posted comments on this change. Change subject: IMPALA-3337: fix "Cancelled" warnings when LIMIT clause is specified ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2964/1/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: Line 651: Status HdfsScanner::CheckAbortOnError(const ErrorMsg& message) const { > I think the new name is clearer than CheckAbortOnError so I'm ok with it. Thanks, I like those names but think I'll leave it as LogOrReturnError() for now until we do some more cleanup to make it clearer what really classifies as a parse/scan error. -- To view, visit http://gerrit.cloudera.org:8080/2964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a91a22608e346ca21a23ea66c855eae54bbced6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
